Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker release matrix workflow #5065

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Add docker release matrix workflow #5065

merged 3 commits into from
Apr 5, 2024
+113 −0

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Apr 5, 2024 •
edited
Loading

Workflow introduced by this PR: pytorch/pytorch#115949

We want to make it generic and call it from validation jobs as well as build jobs.
Test:

 python generate_docker_release_matrix.py --channel nightly
{"include": [{"cuda": "11.8", "cuda_full_version": "11.8.0", "cudnn_version": "8", "image_type": "runtime", "platform": "linux/arm64,linux/amd64"}, {"cuda": "11.8", "cuda_full_version": "11.8.0", "cudnn_version": "8", "image_type": "devel", "platform": "linux/arm64,linux/amd64"}, {"cuda": "12.1", "cuda_full_version": "12.1.1", "cudnn_version": "8", "image_type": "runtime", "platform": "linux/arm64,linux/amd64"}, {"cuda": "12.1", "cuda_full_version": "12.1.1", "cudnn_version": "8", "image_type": "devel", "platform": "linux/arm64,linux/amd64"}]}

Will be removing this from pytorch/pytorch

@vercel Vercel
Copy link

vercel bot commented Apr 5, 2024

@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 5, 2024
huydhn
huydhn reviewed Apr 5, 2024
View reviewed changes
tools/scripts/generate_docker_release_matrix.py Outdated
print(json.dumps(build_matrix))

if __name__ == "__main__":
main(sys.argv[1:])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks weird, I don't think you need to pass sys.argv to argparse like this, just calling options = parser.parse_args() without any arguments works.

huydhn
huydhn approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one minor comment abour how parser.parse_args() is used. The rest LGTM!

@atalman atalman merged commit c1dba5c into pytorch:main Apr 5, 2024
40 of 74 checks passed
@atalman atalman deleted the move_docker_matrix branch April 5, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atalman @huydhn @facebook-github-bot